Onboard Logs service -instance commands #1184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenhoenle
reviewed
Dec 17, 2025
rubenhoenle
reviewed
Dec 17, 2025
rubenhoenle
reviewed
Dec 17, 2025
rubenhoenle
reviewed
Dec 17, 2025
rubenhoenle
reviewed
Dec 17, 2025
rubenhoenle
reviewed
Dec 17, 2025
Co-authored-by: Ruben Hönle <[email protected]>
Co-authored-by: Ruben Hönle <[email protected]>
Co-authored-by: Ruben Hönle <[email protected]>
rubenhoenle
reviewed
Jan 12, 2026
rubenhoenle
reviewed
Jan 12, 2026
rubenhoenle
reviewed
Jan 12, 2026
rubenhoenle
reviewed
Jan 12, 2026
rubenhoenle
reviewed
Jan 12, 2026
rubenhoenle
reviewed
Jan 12, 2026
rubenhoenle
reviewed
Jan 12, 2026
| { | ||
| description: "default output", | ||
| instance: &logs.LogsInstance{}, | ||
| model: &inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{}}, |
Member
There was a problem hiding this comment.
Suggested change
| model: &inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{}}, | |
| model: &inputModel{GlobalFlagModel: nil, |
a testcase like this would also be interesting
Contributor
Author
There was a problem hiding this comment.
This is causing a nil pointer issue. Can global flags really be nil? So far I did not see any similar test case. We might need to look into the configuring and parsing the global flags.
Contributor
Author
There was a problem hiding this comment.
added the unit test and nil check in outputResult function.
Contributor
Author
There was a problem hiding this comment.
added the unit test and nil check also in create command
…to feature/onboard-logs-service
rubenhoenle
reviewed
Jan 19, 2026
| if err != nil { | ||
| return fmt.Errorf("create Logs instance: %w", err) | ||
| } | ||
| instanceId := *resp.Id |
Member
There was a problem hiding this comment.
potential nil pointer dereference
Contributor
Author
There was a problem hiding this comment.
thx for the catch, added two more nil checks
| instanceId := *resp.Id | ||
|
|
||
| // Wait for async operation, if async mode not enabled | ||
| if !model.Async { |
| } | ||
|
|
||
| // Wait for async operation, if async mode not enabled | ||
| if !model.Async { |
rubenhoenle
reviewed
Jan 19, 2026
| return fmt.Errorf("instance is nil") | ||
| } | ||
| var outputFormat string | ||
| if model.GlobalFlagModel != nil { |
Member
There was a problem hiding this comment.
Now you have a nil pointer dereference if model is nil 😉
I propose the following, just throw an error if the input model / the global flag model is nil:
func outputResult(p *print.Printer, model *inputModel, projectLabel string, instance *logs.LogsInstance) error {
if instance == nil {
return fmt.Errorf("instance is nil")
} else if model == nil || model.GlobalFlagModel == nil {
return fmt.Errorf("input model is nil")
}
Contributor
Author
There was a problem hiding this comment.
thx, added the check
rubenhoenle
reviewed
Jan 19, 2026
| var outputFormat string | ||
| var async bool | ||
|
|
||
| if model.GlobalFlagModel != nil { |
Contributor
Author
There was a problem hiding this comment.
thx, added the check :)
Merging this branch changes the coverage (1 decrease, 8 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to STACKITCLI-292
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)